Refs #15188: Refactor Configuration to data structs#250
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 59.75% 59.93% +0.17%
==========================================
Files 94 94
Lines 3223 3145 -78
Branches 1184 1144 -40
==========================================
- Hits 1926 1885 -41
+ Misses 572 566 -6
+ Partials 725 694 -31
Continue to review full report at Codecov.
|
jparisu
force-pushed
the
refactor/public-configuration
branch
from
61173b1 to
76922db
Compare
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
force-pushed
the
refactor/public-configuration
branch
from
76922db to
15a33db
Compare
juanlofer-eprosima
requested changes
Jul 27, 2022
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
added 2 commits
July 28, 2022 09:13
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
force-pushed
the
refactor/public-configuration
branch
from
5f56017 to
723419f
Compare
juanlofer-eprosima
approved these changes
Jul 28, 2022
juanlofer-eprosima
left a comment
juanlofer-eprosima
left a comment
Contributor
There was a problem hiding this comment.
LGTM, waiting for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jparisu javierparis@eprosima.com